Bring back the automation to add kdesrc-build to the path
This commit (which by the way was not reviewed in an MR) removed update-shellrc
, which added kdesrc-build to the path in bash, zsh and fish:
Remove update-shellrc step: 5d7dcace
It basically just added to the shellrc the path to the running script. That is not handled correctly in all cases.
Also, it tried to add kdesrc-run bash autocompletion, but the code was not handling all cases correctly anyway.
Instead, we will offer to install the file in the correct place in the first place. Regarding PATH, that should be in user's control.
This unnecessarily creates one extra step for new users.
The functionality doesn't necessarily need to have the same implementation. As shown in the new method nmariusp found: https://community.kde.org/Get_Involved/development/Set_up_a_development_environment#Set_up_kdesrc-build
A symlink to the well specified ~/.local/bin
directory would work universally with all shells and in distros that care about the XDG spec. This can be done directly in kdesrc-build so the user doesn't have to do the symlinking themselves.
I don't know whether FreeBSD follows the XDG spec.
An acceptable minimum should be to display a message telling the user to symlink (and the right command to do so) themselves, ideally this process would be invisible to the user and they'd just get a message telling them what happened.